Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v1.4.0 of gha-mjolnir #37422

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

thomashampson
Copy link
Contributor

@thomashampson thomashampson commented May 24, 2024

Description of work

Update to 1.4.0 of the workflow we use to close issues with PRs merged into release-next.

Purpose of work

It wasn't working with a full stop was after the issue number:
Fixes #xxxx.
The new version works.

To test:

I've tested it on my Sandbox repo, merging a PR into a non-default branch.
https://github.com/thomashampson/sandbox/pull/35

This does not require release notes because it's a github action update


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

Now allows a full stop after the final issue number.
@thomashampson thomashampson marked this pull request as ready for review May 24, 2024 15:27
@thomashampson thomashampson changed the title Update to 1.4.0 of gha-mjolnir Update to v1.4.0 of gha-mjolnir May 28, 2024
@sf1919 sf1919 added this to the Release 6.10 milestone May 28, 2024
@sf1919 sf1919 added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label May 28, 2024
@cailafinn cailafinn self-assigned this May 28, 2024
@cailafinn cailafinn merged commit bded957 into release-next May 28, 2024
10 checks passed
@cailafinn cailafinn deleted the update-close-issues-action branch May 28, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants