Fix bug where all workspaces are excluded in the Elwin interface when "Restrict allowed input files by name" is deselected

[rosswhitfield]

This bug was introduced by #37193 during this release.

This was discovered during testing for the new release from the BASIS instrument team.

Menu->Interfaces->Inelastic->Data Manipulation. Click the "Elwin" tab.

From the cog icon in the dialog, if you deselect "Restrict allowed input files by name" then no workspaces appear in the "Add Workspaces" dialog.

QStringList{""} is actually creating a list with 1 item that is an empty string instead of creating an empty list. This causes the check WorkspaceMultiSelector::hasValidSuffix to always return false.

Description of work

Summary of work

Fixes 5377: [Defect] Elwin file loading function not working properly in mantidworkbench nightly

Further detail of work

To test:

Menu->Interfaces->Inelastic->Data Manipulation. Click the "Elwin" tab.

Click "Add Workspaces" After valid workspaces are loaded and the "Restrict allowed input files by name" is unchecked, you should be able to see workspaces.

This does not require release notes because it was only introduced during this release.

---

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards?
• Are the unit tests small and test the class in isolation?
• If there is GUI work does it follow the GUI standards?
• If there are changes in the release notes then do they describe the changes appropriately?
• Do the release notes conform to the release notes guide?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?
• Do the changes handle unexpected situations, e.g. bad input?
• Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

[sf1919]

@adriazalvarez Please can you check whether this has already been fixed?

[adriazalvarez]

@sf1919 Not that I know of, it is not fixed on the release candidate

[adriazalvarez]

Thanks for spotting and fixing this. I did a functional test and it is now able to locate the files.

[robertapplin]

Just got back from annual leave - thanks for fixing this!