Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where all workspaces are excluded in the Elwin interface when "Restrict allowed input files by name" is deselected #37430

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix bug where all workspaces are excluded in the Elwin interface when "Restrict allowed input files by name" is deselected #37430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d78d1b
Fix bug where all workspaces are excluded in the Elwin interface when…
rosswhitfield May 29, 2024
4b2b5fa
Update test
rosswhitfield May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qt/scientific_interfaces/Inelastic/Common/InterfaceUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ QStringList getFBSuffixes(std::string const &interfaceName, std::string const &f

QStringList getWSSuffixes(std::string const &interfaceName, std::string const &fileType) {
if (!restrictInputDataByName()) {
return QStringList{""};
return QStringList{};
}
return toQStringList(getInterfaceProperty(interfaceName, "WORKSPACE-SUFFIXES", fileType), ",");
}
Expand Down
2 changes: 1 addition & 1 deletion qt/scientific_interfaces/Inelastic/test/Common/InterfaceUtilsTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class InterfaceUtilsTest : public CxxTest::TestSuite {
InterfaceUtils::restrictInputDataByName = mockRestrictInputDataByName;

// There are many similar functions in the interface, this test will try only one pair of such functions
TS_ASSERT_EQUALS(getResolutionWSSuffixes("Iqt"), QStringList({""}));
TS_ASSERT_EQUALS(getResolutionWSSuffixes("Iqt"), QStringList());
TS_ASSERT_EQUALS(getResolutionFBSuffixes("Iqt"), QStringList({".nxs"}));
}

Expand Down
Loading