-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use int for algorithm property when calling python algorithm from c++ #37456
Use int for algorithm property when calling python algorithm from c++ #37456
Conversation
Should this have a 6.11 milestone instead? The error was introduced into main so will not be in release-next |
Oops, no it should be 6.10 but I forgot to change the base branch! I think the error is in release-next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to write a unit test for this? Doubly important when we can't rely on the compiler to get the typing right.
Its not easy to add a test for this because the code in this area is not in MVP and has Qt everywhere. Instead I have opened a new issue to add manual testing instructions for Inelastic Bayes Fitting. This would catch the problem in the future #37455 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions addressed. Code looks good, it's a minor change. Performed functional tests in description and no longer throws/crashes. Thanks for opening that issue!
Description of work
This PR fixes an error when attempting to use a
long
instead of anint
for a property of a python algorithm. when calling the python algorithm from C++.There was a recent change in behaviour for the
PropertyWithValue
class introduced in #37196 which caused this problem.There is no associated issue.
To test:
This does not require release notes because it is a regression since the last release
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.