Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Inelastic Data Manipulation to Data Processor #37467

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Jun 4, 2024

Description of work

This PR renames the Inelastic Data Manipulation GUI to Data Processor. It only renames things that are user-facing. The relevant classes, files names, folders and documentation refs link will be renamed in a separate maintenance PR.

There is no associated issue.

To test:

  1. Follow the instructions here to test.
    https://developer.mantidproject.org/Testing/Inelastic/DataManipulationTests.html

  2. Build the docs-html target, and check the Data Processor interface documentation uses the correct name

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Indirect/Inelastic Issues and pull requests related to indirect or inelastic labels Jun 4, 2024
@robertapplin robertapplin added this to the Release 6.10 milestone Jun 4, 2024
@robertapplin robertapplin changed the base branch from main to release-next June 4, 2024 15:51
@robertapplin robertapplin force-pushed the 0-rename-data-manipulation-to-data-processor branch from 41d8703 to 389e6a1 Compare June 4, 2024 15:55
@robertapplin robertapplin marked this pull request as ready for review June 4, 2024 15:59
@robertapplin robertapplin requested a review from jmborr June 4, 2024 15:59
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other files that may need update:

@robertapplin
Copy link
Contributor Author

Other files that may need update:

Thanks, the structure.rst will be left for the maintenance issue. The other two I have updated in the latest commit

Copy link

github-actions bot commented Jun 5, 2024

👋 Hi, @robertapplin,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Jun 5, 2024
@robertapplin robertapplin force-pushed the 0-rename-data-manipulation-to-data-processor branch from 9675089 to 3763e74 Compare June 5, 2024 10:28
@robertapplin robertapplin removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Jun 5, 2024
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants