-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Inelastic Data Manipulation to Data Processor #37467
Rename Inelastic Data Manipulation to Data Processor #37467
Conversation
41d8703
to
389e6a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other files that may need update:
- is dev-docs/source/InelasticDataManipulationFileStructure.rst left for the maintenance issue? it's mostly a class diagram.
- I think point 19 of last test in file https://github.com/robertapplin/mantid/blob/0-rename-data-manipulation-to-data-processor/dev-docs/source/Testing/Indirect/DataReductionTests.rst needs to be updated
- I think file https://github.com/robertapplin/mantid/blob/0-rename-data-manipulation-to-data-processor/dev-docs/source/Testing/Inelastic/DataManipulationTests.rst should be updated
Thanks, the structure.rst will be left for the maintenance issue. The other two I have updated in the latest commit |
👋 Hi, @robertapplin, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
9675089
to
3763e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks 👌
Description of work
This PR renames the Inelastic Data Manipulation GUI to Data Processor. It only renames things that are user-facing. The relevant classes, files names, folders and documentation refs link will be renamed in a separate maintenance PR.
There is no associated issue.
To test:
Follow the instructions here to test.
https://developer.mantidproject.org/Testing/Inelastic/DataManipulationTests.html
Build the docs-html target, and check the Data Processor interface documentation uses the correct name
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.