Release notes for 6.11 #38129
Merged
Release notes for 6.11 #38129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran release_editor.py script and commited the resulting changes
GuiMacielPereira
added
the
Documentation
|
There is a |
|
This should be pointing into |
|
Also |
jhaigh0
requested changes
Oct 9, 2024
Co-authored-by: Jonathan Haigh <35813666+jhaigh0@users.noreply.github.com> Co-authored-by: RichardWaiteSTFC <55979119+RichardWaiteSTFC@users.noreply.github.com>
Co-authored-by: Jonathan Haigh <35813666+jhaigh0@users.noreply.github.com>
thomashampson
requested changes
Oct 11, 2024
| The effect is that there is no longer negative bin edges unless there is actually a negative time-of-flight in the data. | ||
| - Isotope densities have been updated, see https://pypi.org/project/periodictable/1.6.1/#history for notes about the updates from NIST. | ||
| - Algorithm `IntegratePeaks1DProfile <algm-IntegratePeaks1DProfile-v1>` no longer references `numpy.distutils`, since as of NumPy 1.23.0 it is deprecated. | ||
| - All sample times are now allowed to be before 01/01/1991. |
There was a problem hiding this comment.
@jclarkeSTFC I think the rewording of this has broken the meaning of the fix. Can you suggest something that describes the fix?
Although it's not directly applicable for users, it's a noteworthy change for developers.
|
I'm happy for this to be merged pending one change to this line, which is a bit confusing: |
jclarkeSTFC
reviewed
Oct 15, 2024
Co-authored-by: James Clarke <139879523+jclarkeSTFC@users.noreply.github.com>
jhaigh0
approved these changes
Oct 16, 2024
thomashampson
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR contains the bulk of the edited release notes
Summary of work
Went over release notes and edited them so they fit the same format.
Further detail of work
To test:
Read over release notes to correct any typos.
Build and open release notes to check for formatting issues.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.