Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for result before removing observers in BatchAlgorithmRunner destructor #38138

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

SilkeSchomann
Copy link
Contributor

@SilkeSchomann SilkeSchomann commented Oct 3, 2024

Description of work

This PR fixes a crash when closing the AlfView interface at the same time as the interface is still loading data.

Closing the AlfView interface results in a call to the destructor of the BatchAlgorithmRunner. If this happens while the interface is still loading data, the notification that data loading is complete causes an exception. A brief wait for the result in the destructor prevents this.

Fixes #38136.

To test:

Follow the instructions on the original issue.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Direct Inelastic Issues and pull requests related to direct inelastic Reported By User Issues that were found or highlighted by a user/scientist ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS labels Oct 3, 2024
@SilkeSchomann SilkeSchomann added this to the Release 6.11 milestone Oct 3, 2024
@SilkeSchomann SilkeSchomann marked this pull request as ready for review October 3, 2024 10:45
@SilkeSchomann SilkeSchomann changed the base branch from main to release-next October 3, 2024 13:24
@SilkeSchomann SilkeSchomann changed the title Cancel running algorithms in destructor Wait for result before removing observers in BatchAlgorithmRunner destructor Oct 7, 2024
Copy link
Contributor

@adriazalvarez adriazalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get a crash following instructions on ALFVIew.
Thanks for fixing this.

@cailafinn cailafinn self-assigned this Oct 9, 2024
@cailafinn cailafinn merged commit 14353e2 into release-next Oct 9, 2024
10 checks passed
@cailafinn cailafinn deleted the 38136_alfview_crash branch October 9, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Direct Inelastic Issues and pull requests related to direct inelastic ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

AlfView crash when clicking close while loading data
3 participants