Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MSlice SHA and added release notes #38199

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

SilkeSchomann
Copy link
Contributor

@SilkeSchomann SilkeSchomann commented Oct 16, 2024

Description of work

Summary of work

Replaced MSlice SHA for Mantid with SHA of current MSlice main branch.

Added release notes for all changes since the last SHA update.

There is no associated issue.

To test:

Double-check SHA with SHA of current MSlice main branch.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added this to the Release 6.11 milestone Oct 16, 2024
@SilkeSchomann SilkeSchomann added Direct Inelastic Issues and pull requests related to direct inelastic ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS labels Oct 16, 2024
@SilkeSchomann SilkeSchomann marked this pull request as ready for review October 16, 2024 09:30
@robertapplin robertapplin self-assigned this Oct 17, 2024
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the new SHA points to the head of the main branch in the mslice repo 👍

@thomashampson thomashampson self-assigned this Oct 17, 2024
@thomashampson thomashampson merged commit 922aab3 into release-next Oct 17, 2024
10 checks passed
@thomashampson thomashampson deleted the mslice_sha_update_6_11 branch October 17, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Direct Inelastic Issues and pull requests related to direct inelastic ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS
Projects
Status: Done
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants