Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ICAT URL for the ISIS facility #38271

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

SilkeSchomann
Copy link
Contributor

@SilkeSchomann SilkeSchomann commented Oct 22, 2024

Description of work

Summary of work

The URL for ICAT changed and had to be updated in Mantid in order to access the catalogue.

Fixes #38267.

To test:

Check that both CatalogLogin and CatalogGetDataFiles are running without an error message.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Found in Beta Issues that were found during the manual/beta/smoke testing period labels Oct 22, 2024
@SilkeSchomann SilkeSchomann added this to the Release 6.11 milestone Oct 22, 2024
@SilkeSchomann SilkeSchomann marked this pull request as ready for review October 22, 2024 10:26
@MohamedAlmaki MohamedAlmaki self-assigned this Oct 22, 2024
Copy link
Contributor

@MohamedAlmaki MohamedAlmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested on Linux and Windows and it is working as expected

@robertapplin robertapplin self-assigned this Oct 22, 2024
@robertapplin robertapplin merged commit 87497fc into release-next Oct 22, 2024
10 checks passed
@robertapplin robertapplin deleted the 38267_update_icat_url branch October 22, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Found in Beta Issues that were found during the manual/beta/smoke testing period High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants