Refactor WildesTest to reduce Code Duplication #38529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2025 09:35
…orrectionWildestest
… code duplication
yusufjimoh
added
Reflectometry
…PolarizationCorrectionWildesTest
yusufjimoh
force-pushed
the
38326-refactor-polarizationcorrectionwildestest-to-reduce-code-duplication
branch
from
e3bbdf0 to
3597c20
Compare
adriazalvarez
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Test are working well and I think is a good step into a better organized test file. I appreciate the effort you have done with this refactoring as it is a complex test suite.
I have some suggestions that I think could improve this refactoring, but please feel free to discuss if you don't agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Refactor WildesTest to reduce Code Duplication
Summary of work
Fixes #38326
To test:
Test should pass
This does not require release notes because it involves code refactoring and improvements