Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added release notes for MSlice #38596

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Added release notes for MSlice #38596

merged 3 commits into from
Jan 14, 2025

Conversation

SilkeSchomann
Copy link
Contributor

@SilkeSchomann SilkeSchomann commented Jan 14, 2025

Description of work

This PR adds the release notes for MSlice for release 6.12. of Mantid.

There is no associated issue.

To test:

Read the release notes and check grammar as well as spelling.

This does not require release notes because these are the release notes :-)


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added the ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS label Jan 14, 2025
@SilkeSchomann SilkeSchomann added this to the Release 6.12 milestone Jan 14, 2025
@SilkeSchomann SilkeSchomann marked this pull request as ready for review January 14, 2025 09:08
Copy link
Contributor

@GuiMacielPereira GuiMacielPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notes were already grammatically correct, I just made a few suggestions on how I prefer release notes to be written. This reminds me that I still haven't organised a discussion on the phrasing of release notes, which I should do at the beginning of next release, so we can all agree on the same kind of phrasing.

Copy link
Contributor

@GuiMacielPereira GuiMacielPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for accepting my suggestions 👍

@thomashampson thomashampson self-assigned this Jan 14, 2025
@thomashampson thomashampson merged commit e4575ed into main Jan 14, 2025
10 checks passed
@thomashampson thomashampson deleted the release_notes_mslice branch January 14, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants