Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML manuscript display enhancements for Q1 2019 #152

Closed
3 of 5 tasks
dhimmel opened this issue Dec 31, 2018 · 7 comments
Closed
3 of 5 tasks

HTML manuscript display enhancements for Q1 2019 #152

dhimmel opened this issue Dec 31, 2018 · 7 comments

Comments

@dhimmel
Copy link
Member

dhimmel commented Dec 31, 2018

The Greene Lab welcomes @vincerubinetti on-board as a frontend developer starting in January 2019. Part of @vincerubinetti's role will be contributing to Manubot, along with @dongbohu. Since I'll be traveling for parts of January, I wanted to jot down some initial tasks which can be started in my absence.

Primarily, it'd be great to improve the HTML display used by Manubot. A quick rundown: Manubot uses Pandoc to generate the HTML Manuscript. The styling of the HTML is controlled by github-pandoc.css, which we took from here and modified slightly over time as issues arose. I am guessing there is large room for improvement.

Here is the current frontend, on the Meta Review manuscript which has a variety of types of content, like figures, tables, and citations:

Here are several enhancements that we can consider for the first quarter of 2019:

@vincerubinetti no pressure to think about any of this until you start, just I wanted to make sure you aren't blocked by me when you do start! Happy New Year everyone.

@slochower
Copy link
Collaborator

This is great. Happy to provide feedback or review things as requested.

@agitter
Copy link
Member

agitter commented Jan 10, 2019

From an overall design standpoint, will these changes only affect the HTML outputs and leave the PDF untouched? Currently pandoc uses github-pandoc.css for both HTML and PDF conversion, right? Will there be separate CSS for HTML and PDF manuscripts as these changes are implemented?

@dhimmel
Copy link
Member Author

dhimmel commented Jan 13, 2019

I was hoping we could continue to use the same CSS for the web view and the PDF that gets exported from it.

@agitter
Copy link
Member

agitter commented Jan 13, 2019

@dhimmel I would like to do that as well for the overall aesthetics, but what about the dynamic elements like tooltips and scroll bars in the HTML version? Will those have to be separated somehow?

@dhimmel
Copy link
Member Author

dhimmel commented Jan 16, 2019

what about the dynamic elements like tooltips and scroll bars in the HTML version? Will those have to be separated somehow?

Perhaps @vincerubinetti can comment, but essentially the PDF is generated as a "printed" version of the webpage using weasyprint. The CSS @page rules allow specifying the style just for the printed version. I imagine tooltips are not a problem as they just won't appear in the printed format?

@vincerubinetti
Copy link
Collaborator

vincerubinetti commented Jan 16, 2019

@agitter If I understand you correctly, yes @dhimmel is right. I've already made it (PR #157) such that the tables will overflow with a scroll bar on a screen (@media only screen) but will squash to the correct width for print (@media print), as is normal behavior for tables. If we want to have more complex behavior like breaking columns to the next page for super wide tables, I believe that is a bit more complex and will have to be looked into.

Also, yes the tooltips aren't visible when printing. They're actually not in the document at all until you hover over a citation link.

@vincerubinetti
Copy link
Collaborator

I think we can probably close this, since these improvements and issues are naturally being broken down into other issues by myself and @dhimmel.

@dhimmel dhimmel closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants