-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML manuscript display enhancements for Q1 2019 #152
Comments
This is great. Happy to provide feedback or review things as requested. |
From an overall design standpoint, will these changes only affect the HTML outputs and leave the PDF untouched? Currently pandoc uses |
I was hoping we could continue to use the same CSS for the web view and the PDF that gets exported from it. |
@dhimmel I would like to do that as well for the overall aesthetics, but what about the dynamic elements like tooltips and scroll bars in the HTML version? Will those have to be separated somehow? |
Perhaps @vincerubinetti can comment, but essentially the PDF is generated as a "printed" version of the webpage using weasyprint. The CSS |
@agitter If I understand you correctly, yes @dhimmel is right. I've already made it (PR #157) such that the tables will overflow with a scroll bar on a screen ( Also, yes the tooltips aren't visible when printing. They're actually not in the document at all until you hover over a citation link. |
I think we can probably close this, since these improvements and issues are naturally being broken down into other issues by myself and @dhimmel. |
The Greene Lab welcomes @vincerubinetti on-board as a frontend developer starting in January 2019. Part of @vincerubinetti's role will be contributing to Manubot, along with @dongbohu. Since I'll be traveling for parts of January, I wanted to jot down some initial tasks which can be started in my absence.
Primarily, it'd be great to improve the HTML display used by Manubot. A quick rundown: Manubot uses Pandoc to generate the HTML Manuscript. The styling of the HTML is controlled by
github-pandoc.css
, which we took from here and modified slightly over time as issues arose. I am guessing there is large room for improvement.Here is the current frontend, on the Meta Review manuscript which has a variety of types of content, like figures, tables, and citations:
Here are several enhancements that we can consider for the first quarter of 2019:
github-pandoc.css
to follow current best practices and consider whether we should migrate to an entirely different solution such as a JATS viewer Look into JATS frontends & the Manuscript Exchange Common Approach #139.@vincerubinetti no pressure to think about any of this until you start, just I wanted to make sure you aren't blocked by me when you do start! Happy New Year everyone.
The text was updated successfully, but these errors were encountered: