New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incosistent behaviour on Methods of Partial CRUD Methods #300

Open

sharpner opened this issue Oct 26, 2017 · 0 comments

Labels

bug help wanted

Milestone

Member

sharpner commented Oct 26, 2017

I stumbled upon this:
https://github.com/manyminds/api2go/blob/master/api_interfaces_test.go#L335
https://github.com/manyminds/api2go/blob/master/api_interfaces_test.go#L440

which seems to have slipped through our eyes. Every tests checks for 405 (even though the description state 404) except the first one for create.

We should investigate what's happening here. If you ask me, every route should return 405 if the route is registered but the method is not.

sharpner added bug help wanted labels

sharpner added this to the Release 1.0 milestone

sharpner changed the title ~~Is this correct behaviour?~~ Incosistent behaviour on Methods of Partial CRUD Methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment