Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using groups layout with cpp tester #30

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

kalabukdima
Copy link
Contributor

C++ tester only supports flat layout right now because it runs build as cmake ${task_dir}/.. assuming that the project root is located one directory up from the task dir.
This PR adds support for the groups layout while preserving functionality for the flat layout.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #30 (c5e7375) into main (6389346) will increase coverage by 8.31%.
Report is 11 commits behind head on main.
The diff coverage is 64.07%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   36.94%   45.25%   +8.31%     
==========================================
  Files          24       25       +1     
  Lines        1903     2022     +119     
==========================================
+ Hits          703      915     +212     
+ Misses       1200     1107      -93     
Flag Coverage Δ
unittests 45.25% <64.07%> (+8.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
checker/__main__.py 0.00% <0.00%> (ø)
checker/actions/check.py 0.00% <0.00%> (ø)
checker/actions/contributing.py 0.00% <ø> (ø)
checker/actions/export.py 0.00% <0.00%> (ø)
checker/actions/grade.py 0.00% <0.00%> (ø)
checker/actions/grade_mr.py 0.00% <0.00%> (ø)
checker/executors/sandbox.py 87.77% <ø> (ø)
checker/utils/git.py 17.50% <ø> (ø)
checker/utils/manytask.py 80.85% <ø> (+62.48%) ⬆️
checker/testers/make.py 44.44% <20.00%> (+44.44%) ⬆️
... and 13 more

@k4black k4black merged commit ad4e2f7 into manytask:main Sep 12, 2023
12 of 16 checks passed
@kalabukdima kalabukdima deleted the cpp-groups branch October 11, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants