Optimization of some functions #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Nov 13, 2023
cthoyt
reviewed
Nov 14, 2023
hrshdhgd
changed the title
cthoyt
reviewed
Nov 20, 2023
cthoyt
reviewed
Nov 20, 2023
cthoyt
reviewed
Nov 20, 2023
| @@ -345,3 +357,76 @@ def test_msdf_from_mappings(self): | |||
| self.assertEqual(1, len(new_msdf.df.index)) | |||
| self.assertEqual(rows[0], tuple(msdf.df.iloc[0])) | |||
| self.assertEqual(new_msdf.metadata, msdf.metadata) | |||
|
|
|||
| def test_get_dict_from_mapping(self): | |||
There was a problem hiding this comment.
this tests many many different things - it's not helpful if we ever need to debug or understand what happened. Instead, it's preferable to make many small, minimal tests for each part of the function that's being tested
cthoyt
reviewed
Nov 20, 2023
cthoyt
reviewed
Nov 20, 2023
cthoyt
reviewed
Nov 20, 2023
src/sssom/util.py
Outdated
| # join all the values into a string separated by '|' | ||
| map_dict[property] = "|".join(enum_value for enum_value in mapping_property) | ||
| elif is_enum: | ||
| # FIXME needs test |
cthoyt
reviewed
Nov 20, 2023
src/sssom/util.py
Outdated
| if isinstance(mapping_property, list): | ||
| # If the property is an enumeration and it allows multiple values | ||
| if is_enum and slot_of_interest["multivalued"]: | ||
| # FIXME needs test |
matentzn
reviewed
Nov 20, 2023
|
I glanced through quickly and couldn't figure out how things are running faster, but glad to hear it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #202
poetry update_get_sssom_schema_object()once in the functionget_dict_from_mapping()rather than multiple times in a for loop that is inefficient.pandas.iterrows()usepandas.apply()in_get_mapping_set_from_df()SchemaViewobject instantiation and persistence@cached_propertythank you @cthoyt