Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: .spod command #108

Closed
wants to merge 3 commits into from
Closed

Conversation

dissidente
Copy link
Contributor

CHANGE: moved friendlyTime() to comand_utility() to be used by other commands
CHANGE: added loginCount and totalTime to the output of getUsersList()

CHANGE: moved friendlyTime() to comand_utility() to be used by other commands
CHANGE: added loginCount and totalTime to the output of getUsersList()
@dissidente dissidente mentioned this pull request May 7, 2020
@marado marado linked an issue May 7, 2020 that may be closed by this pull request
@marado
Copy link
Owner

marado commented Jun 27, 2020

I've refactored your commit a little bit, check the https://github.com/marado/TalkerNode/tree/spod branch.
I'm still not happy with it, tho, because I feel there are two things missing:

  • for online users, .spod should be showing their "live time", not the saved one;
  • these are supposed to be the "top users" but currently .spod is showing all of them.

The first item would serve to fix things like this (pay attention to Mind's login time):

.exa
:: You examine Mind and you see... 
:: Mind was registered at Fri Feb 07 2020 20:40:01 GMT+0000.
:: Mind has spent 2 minutes online.
:: Mind is of rank Juvie, and was last seen at northlands.
:: Mind last logged in at Sat Jun 27 2020 19:42:15 GMT+0100.
:: Mind has logged in 15 times.
.spod

+-- Top Users by login time -------------------------------------------------+

  1 months, 7 days, 16 hours, 50 minutes : Marado
>                              1 minutes : Mind
                              38 seconds : Mindboosternoori
                              21 seconds : Teste
                               8 seconds : Testedois

I'm not totally sure about the best way to tackle the second. I think we could probably add a length as an argument (.spod 0 or .spod -l 0 would show all results, .spod 10 would show 10 results, and .spod would show it with the default number of results, that would be defined in the file itself.

As extras (that can be other issues to implement afterwards), I'd like to see:

  • .spod name highlighting an user other than me
  • .spodlength (or another name) as an admin command that configures/redifines the default .spod length

@marado marado added the WIP work in progress label Jun 27, 2020
@marado
Copy link
Owner

marado commented Jun 28, 2020

For the 2nd of the four checkboxes I added in the previous comment, if we go with the implementation I describe, we'd also be managing to close #72 with this patch.

@marado marado closed this in add5c53 Apr 23, 2021
@marado
Copy link
Owner

marado commented Apr 23, 2021

.spod length argument (including 0), .spodlength and .spod name are going to have their own issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.spod and .spod -l
2 participants