Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/building svg data #11

Merged

Conversation

matthewvanderw
Copy link
Contributor

@matthewvanderw matthewvanderw commented Dec 4, 2024

#10

Updated the building icons to use the correct SVG data from the Heroicons website.

The following icons were updated:

Outlined V3

  • home-modern
  • home
  • building-library
  • building-office
  • building-office-2
  • building-storefront

Solid V3

  • home-modern
  • home
  • building-library
  • building-office
  • building-office-2
  • building-storefront

@markuswustenberg
Copy link
Member

@matthewvanderw thanks for this! I'm not sure how that happened, other than the version upstream I branched from may have had a bug like this, too. 🤷

I can't rebuild from upstream because it was basically a hack in the JS build setup that is long outdated, but perhaps I should have another go at some point. That way, I could get the new micro editions too.

@markuswustenberg markuswustenberg merged commit 2573098 into maragudk:main Dec 6, 2024
19 checks passed
@matthewvanderw
Copy link
Contributor Author

matthewvanderw commented Dec 6, 2024

@markuswustenberg super happy to help! Once I have a gap I am happy to just double check the other icons to make sure they are all good. Let me know 😉

@markuswustenberg
Copy link
Member

@matthewvanderw that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants