About the visible property of the window

[gqf2008]

Delete lines 78 and 108 from freya/crates/renderer/src
/window_state.rs in lines 78 and 108, which has the advantage of not affecting existing functionality and leaving it up to the user to control whether or not the window is displayed, for example the following code

launch_cfg(
    app, LaunchConfig::LaunchConfig::LaunchConfig
    LaunchConfig::<String>::new()
        .with_size(800., 400.)
        .with_state(state)
        .with_window_attributes(|mut window_attributes| {
            if cfg!(target_os = ‘macos’) {
                window_attributes = window_attributes
                    .with_resizable(false)
                    .with_visible(true)
                    .with_fullsize_content_view(true)
                    .with_title_hidden(true)
                    .with_titlebar_transparent(true);
            }
            window_attributes
        })
        .with_icon(LaunchConfig::load_icon(ICON)), .
)

By the way, it would be a good idea to export winit::platform::macos::* and winit::platform::windows::* again, so that the user can have more control over the display of the window

[marc2332]

Hey! How is that affecting your app? The window will get visible in L108, so what's the issue?

[gqf2008]

Some applications do not need to display a window at startup, but only need to start the system tray, and only need to display a window when the user clicks on the system tray, such as background programs that start up along with the system

[marc2332]

Good point, you are right about that 💯

[marc2332]

That code was introduced as a workaround for a bug in accesskit, that bug seems like already got fixed a while ago, I tested it myself and it doesn't seem to happen anymore. So I just opened #930 to remove those lines

[marc2332]

By the way, it would be a good idea to export winit::platform::macos::* and winit::platform::windows::* again, so that the user can have more control over the display of the window

I am not very sold on the idea of reexporting winit window APIs. Ideally, with_window_attributes should only be used when you really need it and in that case you just need to add winit as a dep to your project, which I suppose is what you did

[gqf2008]

Yes, that's what I'm doing right now, but it may bring trouble from inconsistent versions

[gqf2008]

Thanks! I have another request, especially for windows platform, I would like to enable non-main thread to run Eventloop, the application scenario is to wake up the UI interface normally when my application injected into another process via remote thread!

[marc2332]

Couldn't you keep the freya in a separate process?

[gqf2008]

No, because the program is loaded by a dll, not a separate exe.

[marc2332]

I'll see if I can add an option to enable running the eventloop in a secondary thread #943

[marc2332]

Just opened #944

You should now be able to do:

.with_event_loop_builder(|mut ev| {
    ev.with_any_thread(true);
})

[gqf2008]

Great!

[marc2332]

FYI @gqf2008 I had to revert the removal of the code, but, I added a with_visible method for the launch config. #935

[gqf2008]

That's great.

[marc2332]

Thanks for sponsoring me @gqf2008 ! I appreciate it.

[gqf2008]

I'm looking forward to the 1.0 release.