Velocity Sensitivity and other thoughts/discussion

[MichaelPNolan]

I'm getting near to delivering this as a working music unit to a friend. Shipping it from Thailand to UK. I've never given anyone anything I made for real world use before and I've made a lot of things this past couple of years to learn. So i've seen my prototypes develop issues or have bugs. This one
There are 2 views (so far) on velocity sensitivity:

1. No its not there, its just electrical switching of valves or circuits
2. This I found "In the case of an organ, it depends on whether the connection between valve and key is electrical or mechanical. If the connections are mechanical (i.e. the key is linked in some way to the valve mechanism), then the speed with which you depress the key can actually affect the attack and release of the sound. The faster you press (or release) the key, the faster the valve opens (or closes), and the faster the attack (or release). It doesn't have an effect on the volume of the note, though. In an organ where the connection is electric, of course, the switch is either on or off."
   So that would be 2nd no but with possibilities to simulate something. Just wondering what you think

Next. My working box has 8 pots and the adc_modlue running with some merging code back into z_config.h, config.h and ml_synth_organ_example a few bits back into the Core0_setup and Core0_setup and then make sure mappings to midi control changes are there. So, my question is - can I put a branch into your git repository.

1. I'm still learning git_hub and I never made pull requests or used them. I'm using it on my level as a glorified ftp with some versioning/branching.
2. These changes I made are very vanilla with minimal changes to keep to the way the modules are designed. The ADC section is accessible enough - i can see a few tweaks and testing things. I played with static float adcMax = 8192;//410000; 420453 to get the range to work with 9 bit resolution (i tried other resolutions and adcMax). Eventually i figured out that really the ADC is only able to measure at most 2.5v so when you get just over half way on the pot you hit max. So I'm going to put a resistance (or possibly a pot) to calibrate what would seem to be "sensitivity" from the user point of view. I'm using 50k pots. There are 8 in parallel so I guess I'll measure resistance and it is like a voltage divider. When they are turned up - its drawing more current and then I can't program via USB - just noticed that ... so having more resistance to the voltage source can only help.

[MichaelPNolan]

Another thing that i'm struggling with today is that while
Organ_SetDrawbar(id, value); works as you would expect
Organ_SetLeslCtrl(value); no longer has any noticable effect and the earlier install I made it had a dramatic vibrato/rotating speaker effect.

This part doesn't seem to do anything different other than name the parameter speed - it passes the byte parameter to Organ_SetLeslCtrl just the same as Organ_SetCtrl does.

inline void Organ_SetLeslieSpeedNorm(uint8_t unused __attribute__((unused)), uint8_t speed)
{
#ifdef USE_ML_SYNTH_PRO
    OrganPro_SetLeslCtrl(speed);
#else
    Organ_SetLeslCtrl(speed);
#endif
}

So I guess I'm going to dig over in the library because maybe you are more focused on the pro version at the moment.

All the same - super thanks as always for your time - shared libraries and example code. This is my re-education and I've learned a lot figuring my way through your code.

These are listed in the ml_organ.h

#define CTRL_PERC_SWITCH 0
#define CTRL_PERC_SPEED 1
#define CTRL_PERC_NOTE 2
#define CTRL_PERC_LOUD 3
#define CTRL_PERC_POLY 4
#define CTRL_INTR_FEEDBACK 5
#define CTRL_ROTARY_ACTIVE 6

which makes me wonder if somehow Rotary is not active and that is why I hear no change and somehow I have to turn it on using some option that I don't find or understand.
Regards
Michael

[MichaelPNolan]

Ok - i see this is not being called
Organ_PercussionSet(CTRL_ROTARY_ACTIVE);

In your test note section it was called and working ...
but it was called twice in a row. I tried calling it once, didn't work ... so i put it that way .
So that's weird ... ok, now I have more ideas for controls to make this accessible to this user that doesn't apparently know how to map midi controls. Anyway, that's the idea - box, midi, plug in - play with sound and shred R&B/Jazz as this woman can do.
https://soundcloud.com/sophiesmiles/jelly-jelly

She's keen to try it ... I'm scared it will be broken after transport.

[marcel-licence]

I've updated the description: https://github.com/marcel-licence/ML_SynthTools/edit/main/extras/ml_organ.md hope it helps a bit to clarify the usage.

[MichaelPNolan]

Thats how slow I am that I didn't even look properly through all the files and see your documentation in there. Thanks for patiently revealing/explaining it. I'm going through a whole process of understanding how the old hammond's worked to help me with sound design in future. Love the sound Regards Michael

…

On Fri, Jan 21, 2022 at 4:05 AM Marcel ***@***.***> wrote: I've updated the description: https://github.com/marcel-licence/ML_SynthTools/edit/main/extras/ml_organ.md hope it helps a bit to clarify the usage. — Reply to this email directly, view it on GitHub <#5 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALTDOQZQGD7IHUWPYNIDCEDUXB2IXANCNFSM5MLT4XTQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: <marcel-licence/ml_synth_organ_example/repo-discussions/5/comments/2009927 @github.com>

[marcel-licence]

I updated the documentation just some minutes after your request. It was impossible to find ;-)

Yes that is an interesting topic. I also tried to understand the complete process of how the hammond works.

[MichaelPNolan]

I love it, great to play with. The percussion part that B3 have seems well done. It seems you are aware of the various buttons for percussion. I've found videos explains. I tried percussion poly mode but I turned it off because chords were triggering from just playing single bassline notes while holding. So this is why I think Hammond doesn't retrigger percussion if any note is held. I think building a bigger control surface is in order. What to do with pitch wheel? Regards Michael

…

On Sun, Jan 23, 2022, 04:47 Marcel ***@***.***> wrote: I updated the documentation just some minutes after your request. It was impossible to find ;-) Yes that is an interesting topic. I also tried to understand the complete process of how the hammond works. — Reply to this email directly, view it on GitHub <#5 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALTDOQ36OCICEOZ4OCTFCF3UXMQVRANCNFSM5MLT4XTQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: <marcel-licence/ml_synth_organ_example/repo-discussions/5/comments/2025080 @github.com>

[marcel-licence]

Hi Michael,

thank you. Yes poly percussion is useless. If possible I want to add a split for 3 manuals (upper, lower, bass). But it depends on the processing power of the MCU.

Pitch wheel .. hm good question. Pitch bending is not possible. Hm maybe controlling an effect, overdrive ... I have no idea at the moment.

[MichaelPNolan]

Yes, that is what I mean ... some kind of creative way of reading pitch bending wheel ... i'm thinking about how I can turn it into an effect thing like - up means +something, down means -something but how to reset it? Possibly just + adds reverb and - any amount is off switch. Regards Michael

…

On Sun, Jan 23, 2022 at 3:34 PM Marcel ***@***.***> wrote: Hi Michael, thank you. Yes poly percussion is useless. If possible I want to add a split for 3 manuals (upper, lower, bass). But it depends on the processing power of the MCU. Pitch wheel .. hm good question. Pitch bending is not possible. Hm maybe controlling an effect, overdrive ... I have no idea at the moment. — Reply to this email directly, view it on GitHub <#5 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALTDOQ6YK64Z7BAAPPVQ7UTUXO4RZANCNFSM5MLT4XTQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: <marcel-licence/ml_synth_organ_example/repo-discussions/5/comments/2026546 @github.com>

[MichaelPNolan]

So, because this thing I've made - its got 8 pots ADC mapped out - but i'm putting the last bits of code before I mail the device to a friend. I wrote this to use the pitch wheel for changes to parameters because I know whatever midi keyboard they have it's likely to follow the standard and have mod and pitch.

inline void Organ_PercussionViaPitch(uint8_t unused __attribute__((unused)), uint8_t value)
{
  if(value == 0){
    if(pitchedOn>0)
       pitchedOn--;
     else 
       if(pitchedOn<0)
         pitchedOn++;
       else
         percSwitch = false;
  } else 
    if(value == 1){
      pitchedOn++;
      if(pitchedOn>8)
        pitchedOn=8;
    } else
      if(value == 255){
        pitchedOn--;
        if(pitchedOn<-7)
          pitchedOn=-7;
    }
  
    
  if(!percSwitch){       
    if(pitchedOn >2){
        Organ_PercussionSet(CTRL_PERC_SWITCH);
        //Organ_PercussionSet(CTRL_PERC_SWITCH);
        Serial.print("trigPerc");
        percSwitch = true;
    }
    if(pitchedOn < -2){
        Organ_PercussionSet(CTRL_PERC_LOUD);
        Serial.print("trigLoud");
        percSwitch = true;  //this means no more changes until pitch bender returns to mid point
    }
  }
}

So it does seem to work reliably now that if you slide/bend up pitch (my controller has a slidey surface not a wheel) more than a couple of clicks you trigger the percussion effect toggle.
Then if you pitch down it triggers loud (which you don't hear unless percussion effect is enabled.
So this means a player has quick access to switch percussion in and out or adjust it's dynamic.