Skip to content
This repository has been archived by the owner on Mar 10, 2024. It is now read-only.

do not start drag if dnd-nodrag && no dnd-handle #432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrum
Copy link

@adrum adrum commented Jul 5, 2017

Fixes #404

@benxshen
Copy link

I have a small question: what's the difference by returning true/false on dragstart event?

line 98 if (element.attr('draggable') == 'false') return true; returns true;
while your patch if (element.attr('dnd-nodrag') !== undefined && !event._dndHandle) return false; returns false

@adrum
Copy link
Author

adrum commented Jul 17, 2017

I think my instincts told me to return false if the drag did not succeed. I'm not entirely sure what the difference is or what the return value is used for. I can change it to true if that's the correct value to return.

@sneakyfildy
Copy link

sneakyfildy commented Oct 3, 2017

Anyone knows good alternative? This entire tool looks dismantled and overall broken/

What's with pull request?

@PaulDMendoza
Copy link

Great fix. This really needs to be merged into the main branch. It fixed an issue I had where clicking on a drag handle quickly a couple times would cause a couple classes to remain on the element like dndDraggingSource after the click was complete.

benxshen added a commit to benxshen/angular-drag-and-drop-lists that referenced this pull request Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants