This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
Compute placeholder location if target and dnd-list are the same #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge 2.1.0 from dev to master
… itself Suppose all children of a dnd-list have margin and you are about to insert a new item between them. In this case, the event target and the list are the same and the placeholder will be put at the end of the list. In this commit, a correct location for both placeholder and the new element is computed based on the dnd-list itself.
mostafabarmshory
changed the title
|
@marceljuenemann This is a simple effective improvement. I think this could be helpful for others too. Would you please check and accept this request? |
|
It seams this project is not alive any more?! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.