Skip to content

Commit

Permalink
fix: build sdist and wheel for py38 on macos
Browse files Browse the repository at this point in the history
  • Loading branch information
marcelotduarte committed Jan 4, 2025
1 parent b85a62e commit 5fc37ad
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build-wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ jobs:
include = [
{"os": "ubuntu-latest", "arch": "x86_64", "tag": "cp3{8,9,10,11,12}-manylinux_x86_64"},
{"os": "windows-latest", "arch": "x86_64", "tag": "cp3{8,9,10,11,12}-win_amd64"},
{"os": "macos-13", "arch": "universal2", "tag": "cp3{8,9,10}-macosx_universal2"},
{"os": "macos-13", "arch": "x86_64", "tag": "cp38-macosx_x86_64"},
{"os": "macos-13", "arch": "universal2", "tag": "cp3{9,10}-macosx_universal2"},
{"os": "macos-14", "arch": "universal2", "tag": "cp3{11,12}-macosx_universal2"},
]
if "${{ github.event_name }}" != "pull_request":
Expand Down
2 changes: 1 addition & 1 deletion ci/build-wheel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ echo "::endgroup::"
mkdir -p wheelhouse >/dev/null
if [[ $PY_PLATFORM == linux* ]]; then
echo "::group::Build sdist"
uv build --no-build-isolation --sdist -o wheelhouse
uv build -p $PY_VERSION --no-build-isolation --sdist -o wheelhouse
echo "::endgroup::"
fi
echo "::group::Build wheel(s)"
Expand Down
4 changes: 3 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ build-verbosity = 1
skip = [
"cp3{8,9}-musllinux_*",
"cp3{8,9}-manylinux_ppc64le",
"cp38-macosx_universal2",
"cp3{9,10,11,12}-macosx_x86_64",
]

[tool.cibuildwheel.linux]
Expand All @@ -173,7 +175,7 @@ cd /opt/_internal && tar -xvf static-libs-for-embedding-only.tar.xz
repair-wheel-command = "auditwheel repair -L /bases/lib -w {dest_dir} {wheel}"

[tool.cibuildwheel.macos]
archs = "universal2"
archs = "x86_64 universal2"
repair-wheel-command = """
delocate-listdeps {wheel} &&
delocate-wheel --require-archs {delocate_archs} -L bases/lib -w {dest_dir} {wheel}
Expand Down

0 comments on commit 5fc37ad

Please sign in to comment.