Skip to content

Commit

Permalink
Bug 1858724 [wpt PR 42511] - Revert "Skip line caps for closed ellips…
Browse files Browse the repository at this point in the history
…e paths", a=testonly

Automatic update from web-platform-tests
Revert "Skip line caps for closed ellipse paths"

This reverts commit a7c44e6c2a28134ad01add05c3a0b7ec2f6e441a.

Reason for revert: line caps for closed subpath are supposed to be
skipped. But full ellipse are arcs, not closed paths according to
spec, https://html.spec.whatwg.org/multipage/canvas.html#ellipse-method-steps.

Original change's description:
> Skip line caps for closed ellipse paths
>
> As discussed in the github issue, whatwg/html#1079, it's generally agreed to skip drawing line caps for closed paths. Add test cases for full
> ellipse path.
>
> Bug: 644067
>
> Change-Id: I3fde274f4b15a96d4ecaa593b0317c585eeb4a25
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4919559
> Commit-Queue: Yi Xu <yiyixgoogle.com>
> Reviewed-by: Justin Novosad <junovchromium.org>
> Cr-Commit-Position: refs/heads/main{#1208078}

Bug: 644067
Change-Id: Idc4810290d431edc608eaf2cd9d3a35e7f83f9aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935432
Reviewed-by: Jean-Philippe Gravel <jpgravelchromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Commit-Queue: Yi Xu <yiyixchromium.org>
Cr-Commit-Position: refs/heads/main{#1209057}

--

wpt-commits: bbd6ebee4588e0eefef6a63fbb4ceb668d4fe33a
wpt-pr: 42511

UltraBlame original commit: 90b22e81ce378846fa924c1a836e0ae6adf58a71
  • Loading branch information
marco-c committed Oct 30, 2023
1 parent 2d6f65d commit b3ec2a6
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 128 deletions.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2853,23 +2853,6 @@
@assert pixel 50,25 == 0,255,0,255;
expected: green

- name: 2d.path.stroke.prune.ellipse
desc: Zero-length full ellipse are removed before stroking with miters
code: |
ctx.fillStyle = '#0f0';
ctx.fillRect(0, 0, 100, 50);
ctx.strokeStyle = '#f00';
ctx.lineWidth = 100;
ctx.lineCap = 'round';
ctx.lineJoin = 'round';
ctx.beginPath();
ctx.ellipse(25, 25, 0, 0, 0, 0, 2 * Math.PI);
ctx.stroke();
@assert pixel 50,25 == 0,255,0,255;
expected: green

- name: 2d.path.transformation.basic
code: |
Expand Down

0 comments on commit b3ec2a6

Please sign in to comment.