v0.4.1, added headless option to selecnium login handler and made tes…

…t implementation
marcosav · Sep 25, 2022 · e108aec · e108aec
1 parent a97ab93
commit e108aec
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/build.gradle b/build.gradle
@@ -4,7 +4,7 @@ plugins {
 }
 
 group 'com.gmail.marcosav2010'
-version '0.4'
+version '0.4.1'
 
 publishing {
     repositories {
@@ -45,7 +45,7 @@ dependencies {
 
     implementation group: 'org.jsoup', name: 'jsoup', version: '1.15.3'
 
-    implementation group: 'org.seleniumhq.selenium', name: 'selenium-java', version: '4.4.0'
+    testImplementation group: 'org.seleniumhq.selenium', name: 'selenium-java', version: '4.4.0'
 
     implementation group: 'org.projectlombok', name: 'lombok', version: '1.18.22'
     annotationProcessor group: 'org.projectlombok', name: 'lombok', version: '1.18.22'

diff --git a/src/test/java/com/gmail/marcosav2010/myfitnesspal/api/SeleniumLoginHandler.java b/src/test/java/com/gmail/marcosav2010/myfitnesspal/api/SeleniumLoginHandler.java
@@ -5,6 +5,7 @@
 import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.firefox.FirefoxOptions;
 import org.openqa.selenium.remote.RemoteWebDriver;
 import org.openqa.selenium.support.ui.WebDriverWait;
 
@@ -23,13 +24,25 @@ public class SeleniumLoginHandler implements LoginHandler {
     private static final String PASSWORD_FIELD_NAME = "password";
     private static final String SUBMIT_BUTTON_XPATH = "//button[@type='submit']";
 
+    private final boolean headless;
+
+    public SeleniumLoginHandler() {
+        this(true);
+    }
+
+    public SeleniumLoginHandler(boolean headless) {
+        this.headless = headless;
+    }
+
     @Override
     public Map<String, String> login(String url, String username, String password) throws LoginException {
         Map<String, String> cookies = new HashMap<>();
         RemoteWebDriver driver = null;
 
         try {
-            driver = new FirefoxDriver();
+            FirefoxOptions options = new FirefoxOptions();
+            options.setHeadless(headless);
+            driver = new FirefoxDriver(options);
 
             driver.get(url);
 

diff --git a/src/test/java/com/gmail/marcosav2010/myfitnesspal/api/TestMFPSession.java b/src/test/java/com/gmail/marcosav2010/myfitnesspal/api/TestMFPSession.java
@@ -28,7 +28,7 @@ public class TestMFPSession {
     private static final String USER = System.getenv("MFP_USERNAME");
     private static final String PASSWORD = System.getenv("MFP_PASSWORD");
 
-    private final LoginHandler loginHandler = new SeleniumLoginHandler();
+    private final LoginHandler loginHandler = new SeleniumLoginHandler(false);
 
     @Test
     void test() throws IOException, LoginException {