Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for #42, #40 and #37 (Encoding issues with Swedish and Russian chars) #53

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes for #42, #40 and #37 (Encoding issues with Swedish and Russian chars) #53

wants to merge 4 commits into from

Conversation

NewEraCracker
Copy link
Contributor

This is a follow up of the PR #43 and resolves the commit-hell that was there.
Now a set of commits that only contains good code. All the bad code is gone.

Thanks!

Regards,
Jorge Oliveira aka NewEraCracker

@NewEraCracker
Fixes for marekrei#42, marekrei#40 and marekrei#37
da86c69 
Encoding translation is now more transparent and handled in a logical,
albeit hackish, way.

Thanks to @havet and @kofbox for their feedback.
Will be followed by a commit that handles the basename() issue.

Tested and working when encode-explorer is running on Windows platform.
@NewEraCracker
Workaround for basename() issues regarding encoding
3b385e2 
Normalize slashes, add spaces, basename() and then trim back to normal.
@NewEraCracker
BOM sucks. period.
0c9636a 
https://en.wikipedia.org/wiki/Byte_order_mark
@NewEraCracker
Fix marekrei#45
9a4bc8f 
Spotted by @TJuTZu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NewEraCracker