Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for #42, #40 and #37 (Encoding issues with Swedish and Russian chars) #53

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes for #42, #40 and #37 (Encoding issues with Swedish and Russian chars) #53

wants to merge 4 commits into from

Commits on Jul 31, 2016

  1. Fixes for marekrei#42, marekrei#40 and marekrei#37 

    Encoding translation is now more transparent and handled in a logical,
albeit hackish, way.

Thanks to @havet and @kofbox for their feedback.
Will be followed by a commit that handles the basename() issue.

Tested and working when encode-explorer is running on Windows platform.
    @NewEraCracker
    NewEraCracker committed Jul 31, 2016
    Configuration menu
    Copy the full SHA
    da86c69 View commit details
    Browse the repository at this point in the history

  2. Workaround for basename() issues regarding encoding 

    Normalize slashes, add spaces, basename() and then trim back to normal.
    @NewEraCracker
    NewEraCracker committed Jul 31, 2016
    Configuration menu
    Copy the full SHA
    3b385e2 View commit details
    Browse the repository at this point in the history

  3. BOM sucks. period. 

    https://en.wikipedia.org/wiki/Byte_order_mark
    @NewEraCracker
    NewEraCracker committed Jul 31, 2016
    Configuration menu
    Copy the full SHA
    0c9636a View commit details
    Browse the repository at this point in the history

  4. Fix marekrei#45 

    Spotted by @TJuTZu
    @NewEraCracker
    NewEraCracker committed Jul 31, 2016
    Configuration menu
    Copy the full SHA
    9a4bc8f View commit details
    Browse the repository at this point in the history