View childViewEvents should support trigger #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perf concerns.... I will have to run test to find out. Which will goad me to get the perf checker into the repo. Btw, the perf checker will always test against src vs lib. |
paulfalgout
force-pushed
the
feature/view-support-trigger
branch
from
ab1278b
to
1c843fe
Compare
|
I wouldn't be so concerned about perf here since you probably don't have 1000 regions on a view like you might have on a collectionview which is already doing this.. except that.. for sufficiently deep views nesting on an existing app this is going to open the door to deep bubbling.. soo that could slow things down if not managed. |
rafde
approved these changes
Nov 9, 2016
scott-w
reviewed
Nov 9, 2016
| @@ -300,7 +300,7 @@ describe('layoutView', function() { | |||
| var ChildView = Marionette.View.extend({ | |||
| template: false, | |||
| onRender: function() { | |||
| this.triggerMethod('content:rendered'); | |||
There was a problem hiding this comment.
Is this signalling a move towards removing triggerMethod in favour of just using trigger everywhere instead?
There was a problem hiding this comment.
Not directly. That'd be #2508
However if this were a childView of a CollectionView then trigger would work. This PR is just about making sure that trigger works in both places.
There was a problem hiding this comment.
@scott-w would you prefer another childViewEvents https://github.com/marionettejs/backbone.marionette/pull/3247/files#diff-0f13482af07d71e12b54fc8c40be7af6L293 to cover the triggerMethod case?
JSteunou
approved these changes
Nov 9, 2016
|
@paulfalgout regarding perf. no noticeable degradation in render time. |
paulfalgout
force-pushed
the
feature/view-support-trigger
branch
from
1c843fe
to
aec3eb9
Compare
|
I went ahead and added a test so this can get in. Hopefully the new test and the one that changed doesn't last as they're all pretty awful. #3248 |
paulfalgout
force-pushed
the
feature/view-support-trigger
branch
from
aec3eb9
to
2061f12
Compare
I realized that `view._parent` was no longer in use in most cases and only related to a region. Then I made the proxy code a little drier and made the proxy cleanup on the region match the setup
|
@marionettejs/marionette-core I just realized that this change warranted some additional code cleanup. Can I get 👀 again? |
paulfalgout
added a commit
to paulfalgout/backbone.marionette
that referenced
this pull request
Nov 11, 2016
Until marionettejs#3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
|
I think it all checks out @paulfalgout 👍 |
rafde
approved these changes
Nov 14, 2016
denar90
approved these changes
Nov 14, 2016
paulfalgout
added a commit
to paulfalgout/backbone.marionette
that referenced
this pull request
Nov 21, 2016
Until marionettejs#3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
paulfalgout
added a commit
to paulfalgout/backbone.marionette
that referenced
this pull request
Dec 18, 2016
Until marionettejs#3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
paulfalgout
added a commit
to paulfalgout/backbone.marionette
that referenced
this pull request
Dec 30, 2016
Until marionettejs#3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
paulfalgout
added a commit
to paulfalgout/backbone.marionette
that referenced
this pull request
Feb 5, 2017
Until marionettejs#3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
paulfalgout
added a commit
to paulfalgout/backbone.marionette
that referenced
this pull request
Mar 23, 2017
Until marionettejs#3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
paulfalgout
added a commit
to paulfalgout/backbone.marionette
that referenced
this pull request
Apr 30, 2017
Until marionettejs#3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
paulfalgout
added a commit
that referenced
this pull request
Apr 30, 2017
Until #3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
paulfalgout
added a commit
that referenced
this pull request
May 1, 2017
Until #3247 is in, the `_parent` here will skip over the `CollectionView` and trigger on any `View` above the `CollectionView`. For that reason, currently setting the `_parent` here is a bad idea and users will have to listen to the `emptyRegion` or `emptyRegion.currentView`. Until a CollectionView can be treated as a parent of a Region we should leave this line out 😿 Additionally the emptyRegion should be destroyed on clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2667 and #2464
This makes child events consistently work between both views for both
triggerMethodandtriggerCurrently some bubbling exists between view types. This will add additional bubbling. Previous to havingchildViewEventPrefix: falseI would have been against the bubbling, but it can be managed easily now.However we may want to wait until
childViewEventPrefix: falseis the default?@rafde any other perf concerns? I like the consistency, but realize this might be doing more now.. however since it's regions on a view it is probably not an issue. If you think it is an issue perhaps we should consider breaking CollectionView such that it too only works with
triggerMethod?I'm bringing this up now as we could introduce this #3244