Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and reorganize view trigger and entity events unit tests #3535

Merged

Conversation

wesmangum
Copy link
Contributor

Proposed changes

  • Import dependencies to move away from using global ones
  • Use let in favor of this in beforeEach

Link to the issue: #3248

This pr is a small part of the work to refactor the whole unit tests directory. Merging this issue should keep #3248 open

@coveralls
Copy link

Coverage Status

Coverage decreased (-72.1%) to 27.899% when pulling 8fa15a6 on wesmangum:tests/viewEntityEvents-viewTriggers into 91ab7ea on marionettejs:next.

@wesmangum wesmangum force-pushed the tests/viewEntityEvents-viewTriggers branch from 8fa15a6 to f4a3c0e Compare November 10, 2017 18:59
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f4a3c0e on wesmangum:tests/viewEntityEvents-viewTriggers into 91ab7ea on marionettejs:next.

@@ -1,109 +1,138 @@
import Backbone from 'backbone';
import Marionette from '../../src/backbone.marionette';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can remove this import entirely

@wesmangum wesmangum force-pushed the tests/viewEntityEvents-viewTriggers branch from f4a3c0e to 0e668bb Compare November 14, 2017 14:53
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0e668bb on wesmangum:tests/viewEntityEvents-viewTriggers into 7761081 on marionettejs:next.

@wesmangum wesmangum force-pushed the tests/viewEntityEvents-viewTriggers branch from 0e668bb to 24eeb7e Compare November 16, 2017 15:23
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 24eeb7e on wesmangum:tests/viewEntityEvents-viewTriggers into 5813ed2 on marionettejs:next.

@paulfalgout paulfalgout merged commit 92a0535 into marionettejs:next Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants