Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorganize and refactor getOption, bindRequest, and BindEvents unit t… #3547

Merged
merged 1 commit into from
Nov 16, 2017
Merged

reorganize and refactor getOption, bindRequest, and BindEvents unit t… #3547

merged 1 commit into from
Nov 16, 2017

Conversation

wesmangum
Copy link
Contributor

Proposed changes

  • Reorganize tests to match order of codebase
  • Import dependencies to move away from using global ones
  • Use let in favor of this in beforeEach

Link to the issue: #3248

This pr is a small part of the work to refactor the whole unit tests directory. Merging this issue should keep #3248 open

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bad2e83 on wesmangum:tests/common/bindEvents-bindRequest-getOption into 1febce8 on marionettejs:next.

@paulfalgout paulfalgout merged commit 5813ed2 into marionettejs:next Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blikblum blikblum blikblum approved these changes

@paulfalgout paulfalgout paulfalgout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wesmangum @coveralls @paulfalgout @blikblum