Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and reorganize mixins directory unit tests #3551

Merged
merged 3 commits into from
Nov 26, 2017
Merged

refactor and reorganize mixins directory unit tests #3551

merged 3 commits into from
Nov 26, 2017

Conversation

wesmangum
Copy link
Contributor

Proposed changes

  • Reorganize tests to match order of codebase
  • Import dependencies to move away from using global ones
  • Use let in favor of this in beforeEach

Link to the issue: #3248

This pr is a small part of the work to refactor the whole unit tests directory. Merging this issue should keep #3248 open

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e4b4d8e on wesmangum:tests/mixins into 5813ed2 on marionettejs:next.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling da484ac on wesmangum:tests/mixins into 7a4dc5c on marionettejs:next.

@paulfalgout paulfalgout merged commit f083b08 into marionettejs:next Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blikblum blikblum blikblum approved these changes

@paulfalgout paulfalgout paulfalgout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wesmangum @coveralls @paulfalgout @blikblum