Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a resolver for table conversion #12

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

rpaul-stripe
Copy link
Collaborator

This PR changes the behavior of the table conversion code action so that it uses a code action resolver instead of a command. A conflict results when more than one instance of the language server registers a command with the same ID, so we can't register a command with a constant name during language server initialization.

In order to use commands for something like this, we'd need to append some unique identifier to the command ID. In this specific case, using a resolver to decouple the edit from the code action provider seemed like a more idiomatic solution.

This PR also updates the version of Markdoc and introduces support for the config.validation.environment variable, defaulting its value to language-server. This allows custom validation functions to identify the context in which they are being executed.

@rpaul-stripe rpaul-stripe merged commit 95fbe40 into main Oct 17, 2023
2 checks passed
@rpaul-stripe rpaul-stripe deleted the table-conversion-edit branch October 17, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant