Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove context tags #2087

Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat: remove context tags #2087

merged 1 commit into from
Jan 22, 2024

Conversation

LuLaValva
Copy link
Member

Description

  • Remove get and put tags
  • Move remove() to the exit phase of translate in placeholder
    • Should do the same for other translators, but that might be out of scope for this PR

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Jan 22, 2024

⚠️ No Changeset found

Latest commit: 63b18fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ace9e86) 88.48% compared to head (63b18fb) 88.37%.
Report is 5 commits behind head on merge-x.

Additional details and impacted files
@@             Coverage Diff             @@
##           merge-x    #2087      +/-   ##
===========================================
- Coverage    88.48%   88.37%   -0.11%     
===========================================
  Files          324      323       -1     
  Lines        30832    30590     -242     
  Branches      1407     1379      -28     
===========================================
- Hits         27282    27035     -247     
- Misses        3538     3543       +5     
  Partials        12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuLaValva LuLaValva merged commit e2e3fbd into merge-x Jan 22, 2024
7 of 8 checks passed
@LuLaValva LuLaValva deleted the remove-context-tag branch January 22, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant