Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$global hydration #2093

Merged
merged 6 commits into from
Jan 29, 2024
Merged

$global hydration #2093

merged 6 commits into from
Jan 29, 2024

Conversation

LuLaValva
Copy link
Member

Description

  • Set up $global with hydration
  • Changed tests from export const context to including $global in the top-level scope
  • Right now, CSR does not work because it is not configured to pull $global from the top-level scope, this is something we will have to do in a future PR

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@LuLaValva LuLaValva self-assigned this Jan 29, 2024
Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: 7bf8c18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LuLaValva LuLaValva merged commit 688982e into merge-x Jan 29, 2024
6 checks passed
@LuLaValva LuLaValva deleted the client-global branch January 29, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant