Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with Nx 17 #108

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Conversation

mapolonio
Copy link
Contributor

@mapolonio mapolonio commented Nov 1, 2023

Problem

In Nx 17 runTasksInSerial is no longer exported from @nx/workspace and instead it must be imported from @nx/devkit.

There is also an issue with addDependenciesToPackageJson that arises when a project using Nx 17 omits the --includeAxe flag when calling the nx-playwright generator. Looks like the undefined value is no longer supported.

Solution

  • All runTasksInSerial imports now come from @nx/devkit
  • addDependenciesToPackageJson call refactored so the axe-playwright is omitted instead of set to undefined when --includeAxe flag is missing
  • Bumped pnpm to >= 8.9 in the engines section because CI was picking Node v20 and pnpm v7.x.x which resulted in a failed prepare step
  • Added --e2eTestRunner=playwright and --nextAppDir=false flags to the "Test plugin" step in the PR validation as the --interactive=false option is not enough to suppress those two prompts

Useful documentation

@prabhatthapa prabhatthapa merged commit e7096f1 into marksandspencer:main Nov 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants