Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In Nx 17
runTasksInSerial
is no longer exported from@nx/workspace
and instead it must be imported from@nx/devkit
.There is also an issue with
addDependenciesToPackageJson
that arises when a project using Nx 17 omits the--includeAxe
flag when calling thenx-playwright
generator. Looks like theundefined
value is no longer supported.Solution
runTasksInSerial
imports now come from@nx/devkit
addDependenciesToPackageJson
call refactored so theaxe-playwright
is omitted instead of set toundefined
when--includeAxe
flag is missingpnpm
to>= 8.9
in the engines section because CI was pickingNode v20
andpnpm v7.x.x
which resulted in a failedprepare
step--e2eTestRunner=playwright
and--nextAppDir=false
flags to the "Test plugin" step in the PR validation as the--interactive=false
option is not enough to suppress those two promptsUseful documentation