Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility Test coverage #1057

Merged
merged 30 commits into from
Dec 31, 2024
Merged

Conversation

adityabharadwaj198
Copy link
Member

@adityabharadwaj198 adityabharadwaj198 commented Dec 1, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • feature

  • What is the current behavior? (You can also link to an open issue here)

  • Currently there are limited compatibility tests

  • What is the new behavior (if this is a feature change)?

  • more compatibility tests added as part of this PR

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Sample run - https://github.com/marqo-ai/marqo/actions/runs/12542408189/job/34972376976#step:7:3587

  • Related Python client changes (link commit/PR here)

  • NA

  • Related documentation changes (link commit/PR here)

  • NA

  • Other information:

  • NA

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

…aditya/comp-test-coverage

# Conflicts:
#	tests/compatibility_tests/compatibility_test_runner.py
Merging mainline into aditya/comp-test-coverage as it's quiet behind mainline and also possible contains different commits
… exception trace in test_vector_normalisation.py and removing unused code from compatibility_test_runner.py
…sentence-transformers/all-MiniLM-L6-v2 to fix error of

marqo.errors.MarqoWebError: MarqoWebError: MarqoWebError Error message: {'message': '[{"loc": ["__root__"], "msg": "Custom vector must have dimension of 768, but given vector is of length 384", "type": "value_error"}]', 'code': 'invalid_argument', 'type': 'invalid_request', 'link': ''}
@adityabharadwaj198 adityabharadwaj198 merged commit e7d04cc into mainline Dec 31, 2024
42 of 44 checks passed
@adityabharadwaj198 adityabharadwaj198 deleted the aditya/comp-test-coverage branch December 31, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants