-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding marqtune model names to model_registry.py #1063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 9, 2024 12:18 — with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 9, 2024 12:19 — with
GitHub Actions
Failure
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 9, 2024 12:19 — with
GitHub Actions
Error
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 9, 2024 13:43 — with
GitHub Actions
Error
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 9, 2024 13:43 — with
GitHub Actions
Error
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 9, 2024 13:44 — with
GitHub Actions
Error
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 9, 2024 13:51 — with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 9, 2024 13:51 — with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 9, 2024 13:52 — with
GitHub Actions
Failure
farshidz
reviewed
Dec 9, 2024
tests/backwards_compatibility_tests/test_general_compatibility.py
Outdated
Show resolved
Hide resolved
tests/s2_inference/embeddings_reference/embeddings_open_clip_python_3_8.json
Outdated
Show resolved
Hide resolved
wanliAlex
requested changes
Dec 10, 2024
wanliAlex
requested changes
Dec 10, 2024
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 10, 2024 11:50 — with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 10, 2024 11:50 — with
GitHub Actions
Failure
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 10, 2024 11:50 — with
GitHub Actions
Failure
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 11, 2024 07:49 — with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 11, 2024 07:49 — with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 11, 2024 07:50 — with
GitHub Actions
Failure
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 11, 2024 08:41 — with
GitHub Actions
Failure
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 11, 2024 09:14 — with
GitHub Actions
Error
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 11, 2024 11:12 — with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 11, 2024 11:12 — with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 11, 2024 11:13 — with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 11, 2024 13:02 — with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 11, 2024 13:02 — with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 11, 2024 13:03 — with
GitHub Actions
Inactive
wanliAlex
previously approved these changes
Dec 12, 2024
farshidz
reviewed
Dec 12, 2024
tests/s2_inference/embeddings_reference/embeddings_open_clip_python_3_8.json
Show resolved
Hide resolved
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 12, 2024 09:55 — with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
December 12, 2024 09:55 — with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 12, 2024 09:55 — with
GitHub Actions
Inactive
farshidz
previously approved these changes
Dec 12, 2024
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 15, 2024 14:54 — with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 15, 2024 14:54 — with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
December 15, 2024 14:55 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Currently there are models defined in marqo repository but they are not defined using the hugging face standard (Marqtune defines using hugging face standard). This change fixes that
What is the current behavior? (You can also link to an open issue here)
Marqtune model names are defined in Marqo's own standard
What is the new behavior (if this is a feature change)?
Marqtune model names will be defined with hugging face standard also
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
NA
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
NA
Related documentation changes (link commit/PR here)
NA
Other information:
NA
Please check if the PR fulfills these requirements