Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding marqtune model names to model_registry.py #1063

Merged
merged 9 commits into from
Dec 15, 2024

Conversation

adityabharadwaj198
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Currently there are models defined in marqo repository but they are not defined using the hugging face standard (Marqtune defines using hugging face standard). This change fixes that

  • What is the current behavior? (You can also link to an open issue here)
    Marqtune model names are defined in Marqo's own standard

  • What is the new behavior (if this is a feature change)?

  • Marqtune model names will be defined with hugging face standard also

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • NA

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Yes

  • Related Python client changes (link commit/PR here)

  • NA

  • Related documentation changes (link commit/PR here)

  • NA

  • Other information:

  • NA

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

src/marqo/s2_inference/model_registry.py Outdated Show resolved Hide resolved
src/marqo/s2_inference/model_registry.py Outdated Show resolved Hide resolved
src/marqo/s2_inference/model_registry.py Outdated Show resolved Hide resolved
wanliAlex
wanliAlex previously approved these changes Dec 12, 2024
src/marqo/s2_inference/model_registry.py Outdated Show resolved Hide resolved
farshidz
farshidz previously approved these changes Dec 12, 2024
@adityabharadwaj198 adityabharadwaj198 merged commit 0daa36b into mainline Dec 15, 2024
3 checks passed
@adityabharadwaj198 adityabharadwaj198 deleted the aditya/marqtune-model-names branch December 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants