-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate coverage report for new code and show all reports in GH step summary #1067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Majorly I have only 1 comment:
we should also fail the job / mark the PR as unable to merge if the test coverage percentage is below a certain threshold. Suggestions:
- test coverage > 90%
- New line coverage > 95%
- New branch coverage > 95%
Further we could introduce some condition like "new test coverage of the codebase should improve by 0.1% from current test coverage".
@adityabharadwaj198 , Thanks for the comments. |
dc0c936
to
09e2d8b
Compare
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Operational improvement
What is the current behavior? (You can also link to an open issue here)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
No
Related Python client changes (link commit/PR here)
No
Related documentation changes (link commit/PR here)
No
Other information:
Please check if the PR fulfills these requirements