Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate coverage report for new code and show all reports in GH step summary #1067

Merged
merged 24 commits into from
Dec 22, 2024

Conversation

papa99do
Copy link
Collaborator

@papa99do papa99do commented Dec 11, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Operational improvement

  • What is the current behavior? (You can also link to an open issue here)

  • we do not generate coverage report for new codes only
  • we do not generate test report for largemodel unit test
  • we do not display test and coverage summary in GH step summary
  • What is the new behavior (if this is a feature change)?
  • generate coverage report for new codes only ( we do not fail on the coverage threshold for now until we merge the coverage report of largemodel and unit tests)
  • generate test report for largemodel unit test
  • display test and coverage summary in GH step summary
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    No

  • Related Python client changes (link commit/PR here)
    No

  • Related documentation changes (link commit/PR here)
    No

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@papa99do papa99do changed the title Yihan/report test coverage Generate coverage report for new code and show all reports in GH step summary Dec 12, 2024
@papa99do papa99do marked this pull request as ready for review December 12, 2024 05:32
Copy link
Member

@adityabharadwaj198 adityabharadwaj198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Majorly I have only 1 comment:
we should also fail the job / mark the PR as unable to merge if the test coverage percentage is below a certain threshold. Suggestions:

  1. test coverage > 90%
  2. New line coverage > 95%
  3. New branch coverage > 95%

Further we could introduce some condition like "new test coverage of the codebase should improve by 0.1% from current test coverage".

@papa99do
Copy link
Collaborator Author

@adityabharadwaj198 , Thanks for the comments.
The fail-on-coverage change will come later. We need to combine coverage report for unit-test run and largemodel-unit-test run to make it work. Otherwise, any change that's only covered by one of the test run will fail the other one.

@papa99do papa99do force-pushed the yihan/report-test-coverage branch from dc0c936 to 09e2d8b Compare December 20, 2024 00:03
@papa99do papa99do merged commit 5c45824 into mainline Dec 22, 2024
9 checks passed
@papa99do papa99do deleted the yihan/report-test-coverage branch December 22, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants