Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme docker run example #990

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

vicilliar
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    readme fix

  • What is the current behavior? (You can also link to an open issue here)
    typos in readme docker container run examples

  • What is the new behavior (if this is a feature change)?
    removed redundant docker in examples, fixed --name flag

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@papa99do papa99do force-pushed the joshua/fix-readme-docker-example branch from e0cbddd to 719c36b Compare October 31, 2024 22:36
@papa99do papa99do temporarily deployed to marqo-test-suite October 31, 2024 22:37 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite October 31, 2024 22:37 — with GitHub Actions Inactive
@papa99do papa99do temporarily deployed to marqo-test-suite October 31, 2024 22:37 — with GitHub Actions Inactive
@papa99do papa99do merged commit dab8a08 into mainline Dec 24, 2024
2 of 3 checks passed
@papa99do papa99do deleted the joshua/fix-readme-docker-example branch December 24, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants