Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run baselines for diva #523

Closed
smilesun opened this issue Oct 12, 2023 · 35 comments
Closed

run baselines for diva #523

smilesun opened this issue Oct 12, 2023 · 35 comments
Assignees

Comments

@smilesun
Copy link
Collaborator

smilesun commented Oct 12, 2023

git checkout fbopt
git pull
./run_benchmark_slurm.sh examples/benchmark/pacs_diva_fbopt_and_others.yaml 10
@DanScarc
Copy link
Collaborator

I could also commit the change in examples/benchmark/pacs_diva_others.yaml if you want.

@smilesun
Copy link
Collaborator Author

smilesun commented Oct 12, 2023 via email

@smilesun smilesun added the fbopt label Oct 12, 2023
@smilesun
Copy link
Collaborator Author

@DanScarc , don't forget to

git checkout fbopt
git pull # i have updated a lot of codes
rm -r zoutput
rm -r runs
rm .snakemake

@DanScarc
Copy link
Collaborator

DanScarc commented Oct 13, 2023

When exactly did you push the last updates? I submitted the jobs ~3hrs ago successfully. CUDA errors have disappeared after the installation update in #540.

@smilesun
Copy link
Collaborator Author

could you post the commit.txt file in zoutput folder of your submission?

@DanScarc
Copy link
Collaborator

DanScarc commented Oct 14, 2023

Sorry, I am not sure I understand what I am supposed to post. What should be in commit.txt? Am I supposed to upload inside and send it together with zoutput folder once results are done?

@smilesun
Copy link
Collaborator Author

in the zouput folder, there should be a text file called commit.txt, did you find it? you can open the file and let me know the text inside, just post the text message in commit.txt here?

@DanScarc
Copy link
Collaborator

use git log |grep
consider remove leading b in the line below
b771b0c8b

@smilesun
Copy link
Collaborator Author

commit 771b0c8 (HEAD -> fbopt, origin/fbopt)
Author: Xudong Sun smilesun@users.noreply.github.com
Date: Sat Oct 14 00:13:05 2023 +0200

Create pacs_jigen_baslines4fbopt.yaml

that commit is not 3 hours ago when you wrote the message 8 hour ago.

@DanScarc
Copy link
Collaborator

Okay then should I rerun everything again if the new commit is relevant to my task?

@smilesun
Copy link
Collaborator Author

it looks like your code is the latest already

@DanScarc
Copy link
Collaborator

How did you assess that?

@smilesun
Copy link
Collaborator Author

When exactly did you push the last updates? I submitted the jobs ~3hrs ago successfully. CUDA errors have disappeared after the installation update in #540.

this message you sent at around 00:20 today so 3 hours ago means 21:20 on Friday.

inside a github repository, you could search a specific commit via
git show 771b0c8b

from the following file you sent upstairs:


use git log |grep
consider remove leading b in the line below
b771b0c8b

where I have removed the first "b" in the git commit hash.

This file is generated everytime you submit a benchmark, it is generated inside the zoutput folder when you submitted your job on the cluster.

@smilesun
Copy link
Collaborator Author

smilesun commented Oct 14, 2023

git show command let you know the time of commit, and also commit message, you can search also in the pr here

#462

of all commit hashes in fbopt branch.

@smilesun
Copy link
Collaborator Author

When exactly did you push the last updates? I submitted the jobs ~3hrs ago successfully. CUDA errors have disappeared after the installation update in #540.

so you did a resubmition at 00:20 on saturday before which you killed the jobs you submitted "3 hours ago"?

@DanScarc
Copy link
Collaborator

No, I submitted the jobs at around 9pm on Friday. Did not resubmit anything after that.
That was it.

@DanScarc
Copy link
Collaborator

That's why I am saying maybe it's better to resubmit everything to be sure. But you decide.

@smilesun
Copy link
Collaborator Author

use git log |grep
consider remove leading b in the line below
b771b0c8b

if you submitted 21:00 on Friday it is not possible to have this commit message since this commit message only exsit after Saturday 00:13, did you run "git update" in between in the repository? even that is not possible, since the commit.txt should be generated when the submission started and not possible to be changed anymore even when you re-submit

@smilesun
Copy link
Collaborator Author

we have to know how did you get this commit.txt file

@smilesun
Copy link
Collaborator Author

smilesun commented Oct 14, 2023

you could also post the results of

git status
and
git log

here

the command should be executed in your folde where the job is submitted on the cluster at 21:00 Friday , you could make screen shot as well and paste the image here.

@DanScarc
Copy link
Collaborator

When I type git show 771b0c8b on fbopt, I get:

Screenshot 2023-10-14 at 09 45 48

whose author is you, not me. So this commit does not map to something I submitted.

@DanScarc
Copy link
Collaborator

DanScarc commented Oct 14, 2023

Today, before branching off fbopt to fbopt-readme-typo, I pulled the changes from fbopt. Could it be that I also pulled your last commit's commit.txt that went into my zoutput folder?

@smilesun
Copy link
Collaborator Author

You pulled the lastest, that is why git log shows the lastest message.
but
zoutput/benchmarks/xxx/commit.txt is not synced at all from github, since the folder zoput is not synced at all.

the commit.txt message can not be created out of magic

@smilesun
Copy link
Collaborator Author

could you send a screen shot of
when you cd into the DomainLab folder on the cluster,
type

cat zoutput/benchmarks/xxx/commit.txt
?

@smilesun
Copy link
Collaborator Author

could you also do

cat zoutput/benchmarks/xx/rule_resulsts/*.csv and send the screen shot?

@smilesun
Copy link
Collaborator Author

could you do

ls -la commit.txt ?

let us see when that commit.txt is generated

@DanScarc
Copy link
Collaborator

cat [...]

Screenshot 2023-10-14 at 09 58 03

cat zoutput/benchmarks/xx/rule_resulsts/*.csv

Screenshot 2023-10-14 at 10 01 48 Screenshot 2023-10-14 at 10 02 23 Screenshot 2023-10-14 at 10 03 09

ls -la commit.txt

Screenshot 2023-10-14 at 10 05 26

@DanScarc
Copy link
Collaborator

I understand zoutput/ is not synced but 09:06 is exactly when I pulled.

@smilesun
Copy link
Collaborator Author

the only possibility for commit.txt to be modifed on 9:06 is the cluster jobs has waited from 21:00 last night until 9:00 this morning to be executed, but that is not possible since so many jobs have been finished already.

In any sense, we need at partly of these results so just keep them running and let us see.

Could you do

cat zoutput/bencmarks/pacs_diva_fbopt_and_others/rule_results/*.csv > rst.txt

and send me the txt file

@smilesun
Copy link
Collaborator Author

if not possible, you do not have to send, then

ls -la rule_results

the time stamp for some csv file should be between 21:00 yesterday and 9:00 today.

@DanScarc
Copy link
Collaborator

ls -la rule_results

Screenshot 2023-10-14 at 10 28 08

@DanScarc
Copy link
Collaborator

How did you find the results, by the way?

@DanScarc
Copy link
Collaborator

rst.txt

There you go.

@smilesun
Copy link
Collaborator Author

How did you find the results, by the way?

parts of the results will be used

@smilesun
Copy link
Collaborator Author

could you do this one?

#546

@smilesun smilesun reopened this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants