Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fbopt #462

Open
wants to merge 1,051 commits into
base: master
Choose a base branch
from
Open

Fbopt #462

wants to merge 1,051 commits into from

Conversation

smilesun
Copy link
Collaborator

No description provided.

@smilesun smilesun added the fbopt label Sep 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Attention: Patch coverage is 63.17241% with 267 lines in your changes are missing coverage. Please review.

Project coverage is 91.33%. Comparing base (1577a7e) to head (7bdf2ef).
Report is 58 commits behind head on master.

Files Patch % Lines
domainlab/utils/generate_fbopt_phase_portrait.py 0.00% 199 Missing ⚠️
domainlab/algos/trainers/fbopt_setpoint_ada.py 81.34% 25 Missing ⚠️
domainlab/algos/trainers/fbopt_mu_controller.py 89.91% 12 Missing ⚠️
domainlab/models/model_diva.py 73.80% 11 Missing ⚠️
domainlab/algos/builder_fbopt_dial.py 44.44% 5 Missing ⚠️
domainlab/algos/trainers/train_fbopt_b.py 92.85% 5 Missing ⚠️
domainlab/algos/trainers/train_dial.py 33.33% 2 Missing ⚠️
domainlab/models/model_hduva.py 75.00% 2 Missing ⚠️
domainlab/algos/msels/a_model_sel.py 80.00% 1 Missing ⚠️
domainlab/algos/msels/c_msel_val_top_k.py 96.29% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   95.15%   91.33%   -3.83%     
==========================================
  Files         127      135       +8     
  Lines        4994     5699     +705     
==========================================
+ Hits         4752     5205     +453     
- Misses        242      494     +252     
Flag Coverage Δ
unittests 91.33% <63.17%> (-3.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilesun smilesun self-assigned this Oct 3, 2023
@smilesun
Copy link
Collaborator Author

now this branch contains old code
https://github.com/marrlab/DomainLab/tree/fbopt_depreciated

@smilesun smilesun mentioned this pull request Oct 14, 2023
@smilesun smilesun changed the title Fbopt aFbopt Oct 15, 2023
@smilesun smilesun changed the title aFbopt Fbopt Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants