Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml: go back to 3.9 since snakemake does not work with later versions #745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smilesun
Copy link
Collaborator

No description provided.

@smilesun smilesun requested a review from agisga January 15, 2024 16:06
@smilesun smilesun changed the title Update ci.yml: go back to 3.9 since CI does not work Update ci.yml: go back to 3.9 since snakemake does not work with later versions Jan 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5043785) 95.05% compared to head (b167fbc) 95.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   95.05%   95.03%   -0.03%     
==========================================
  Files         125      125              
  Lines        4911     4910       -1     
==========================================
- Hits         4668     4666       -2     
- Misses        243      244       +1     
Flag Coverage Δ
unittests 95.03% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -17,7 +17,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.10.7
python-version: 3.9
Copy link
Collaborator

@agisga agisga Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears inconsistent with some changes in the other PR: #743
Can both PRs coexist, or do you plan to discard one of the two?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agisga we need a PR that could let the CI pass, none of the two passes so we don't have to approve them?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good point. I agree, we need to understand what exactly is going on with the CI and how it can be resolved, before we merge any of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants