Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml: go back to 3.9 since snakemake does not work with later versions #745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ci.yml: go back to 3.9 since snakemake does not work with later versions #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.10.7
python-version: 3.9
Copy link
Collaborator

@agisga agisga Jan 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears inconsistent with some changes in the other PR: #743
Can both PRs coexist, or do you plan to discard one of the two?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agisga we need a PR that could let the CI pass, none of the two passes so we don't have to approve them?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good point. I agree, we need to understand what exactly is going on with the CI and how it can be resolved, before we merge any of them.

- name: test if api works before setup install since setup install miss data
run: pip install domainlab && cd examples/api/ && python jigen_dann_transformer.py
- name: Install dependencies
Expand Down
Loading