Use JSON polymorphism with RC2 nightly. #1437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use JSON polymorphism to (de)serialize Alexa requests and responses.
Update to the latest daily build of .NET 9.
Attempt to debug JSON payloads.
* Update .NET SDK Update .NET SDK to version 9.0.100-rc.2.24462.3. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 9.0.100-rc.2.24462.3 SDK. Bumps Microsoft.AspNetCore.WebUtilities from 9.0.0-rc.2.24460.5 to 9.0.0-rc.2.24461.26. Bumps Microsoft.Extensions.Configuration.Binder from 9.0.0-rc.2.24459.11 to 9.0.0-rc.2.24461.13. Bumps Microsoft.Extensions.Configuration.EnvironmentVariables from 9.0.0-rc.2.24459.11 to 9.0.0-rc.2.24461.13. Bumps Microsoft.Extensions.Configuration.Json from 9.0.0-rc.2.24459.11 to 9.0.0-rc.2.24461.13. Bumps Microsoft.Extensions.DependencyInjection from 9.0.0-rc.2.24459.11 to 9.0.0-rc.2.24461.13. Bumps Microsoft.Extensions.Http from 9.0.0-rc.2.24459.11 to 9.0.0-rc.2.24461.13. Bumps Microsoft.Extensions.Logging.Console from 9.0.0-rc.2.24459.11 to 9.0.0-rc.2.24461.13. Bumps System.Text.Json from 9.0.0-rc.2.24459.11 to 9.0.0-rc.2.24461.13. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.WebUtilities dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.EnvironmentVariables dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Json dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.DependencyInjection dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging.Console dependency-type: direct:production update-type: version-update:semver-major - dependency-name: System.Text.Json dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com>
Add more logging to see where the hang is happening.
Avoid deadlock in AoT tests when writing to the console.
Disable the tests entirely - will probably cause a deadlock when deployed, but let's see...
Do not await the handler to see if the things get logged.
Disable logging to the console.
Remove changes made while debugging hang.
* Update .NET SDK Update .NET SDK to version 9.0.100-rc.2.24463.1. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 9.0.100-rc.2.24463.1 SDK. Bumps Microsoft.AspNetCore.WebUtilities from 9.0.0-rc.2.24461.26 to 9.0.0-rc.2.24462.10. Bumps Microsoft.Extensions.Configuration.Binder from 9.0.0-rc.2.24461.13 to 9.0.0-rc.2.24462.5. Bumps Microsoft.Extensions.Configuration.EnvironmentVariables from 9.0.0-rc.2.24461.13 to 9.0.0-rc.2.24462.5. Bumps Microsoft.Extensions.Configuration.Json from 9.0.0-rc.2.24461.13 to 9.0.0-rc.2.24462.5. Bumps Microsoft.Extensions.DependencyInjection from 9.0.0-rc.2.24461.13 to 9.0.0-rc.2.24462.5. Bumps Microsoft.Extensions.Http from 9.0.0-rc.2.24461.13 to 9.0.0-rc.2.24462.5. Bumps Microsoft.Extensions.Logging.Console from 9.0.0-rc.2.24461.13 to 9.0.0-rc.2.24462.5. Bumps System.Text.Json from 9.0.0-rc.2.24461.13 to 9.0.0-rc.2.24462.5. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.WebUtilities dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.EnvironmentVariables dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Json dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.DependencyInjection dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging.Console dependency-type: direct:production update-type: version-update:semver-major - dependency-name: System.Text.Json dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
+ Coverage 93.23% 93.27% +0.04%
==========================================
Files 45 49 +4
Lines 606 610 +4
Branches 55 55
==========================================
+ Hits 565 569 +4
Misses 24 24
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/deploy |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify fix for dotnet/runtime#107740.