power_profiles_daemon: Move to org.freedesktop.UPower.PowerProfiles #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.20 moved to D-Bus name `org.freedesktop.UPower.PowerProfiles`, and corresponding changes to the object path/interface: https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/releases/0.20 The real daemon also still listens to the old name, but we can't do that in dbusmock: BUS_NAME and friends cannot be parameterized, as their loading and instantiation happens before calling the `load()` function. `powerprofilesctl` now only looks at the new name, so we need to adjust the template. The new version is in Fedora 39 to rawhide and also in Debian testing, so for ongoing development it's more useful to present the current API.
|
Well... Apps and libraries are all using the old name though, so not sure if that's too early or she should duplicate it instead? |
|
@3v1n0 not sure, you tell me -- we could of course copy the whole template as power_profiles_daemon_upower.py or so? |
|
It seems safer to me, yes. Maybe using prefixed name though: So we have both and can migrate apps using it without breaking them. |
|
In retrospect this was a silly move, sorry. I'll retract today's releases and work on a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.20 moved to D-Bus name
org.freedesktop.UPower.PowerProfiles, and corresponding changes to the object path/interface: https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/releases/0.20The real daemon also still listens to the old name, but we can't do that in dbusmock: BUS_NAME and friends cannot be parameterized, as their loading and instantiation happens before calling the
load()function.powerprofilesctlnow only looks at the new name, so we need to adjust the template. The new version is in Fedora 39 to rawhide and also in Debian testing, so for ongoing development it's more useful to present the current API.See recent test failures