Handle spurious "connection refused" when sending a uevent #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error was already being handled on the `connect` call right above these changes, but wasn't being handled on the call to `sendmsg`. Depending on the timing it was possible for the `connect` call to succeed while the `sendmsg` call failed with an ECONNREFUSED error leading to the test crashing from the abort call.
bobhenz-jabil
force-pushed
the
fix-spurious-conn-refused-crash
branch
from
69adc52
to
61a2378
Compare
|
@martinpitt: I'm back with another PR. Let me know if you have questions or want changes. |
martinpitt
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Thanks @bobhenz-jabil ! The duplication is a bit annoying, but C just sucks at error handling.. 😅
I retried the (hopefully spurious) CentOS 10 failure. I don't see how python3-dnf would really disappear, this just sounds like a package mirror hiccup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error was already being handled on the
connectcall right above these changes, but wasn't being handled on the call tosendmsg. Depending on the timing it was possible for theconnectcall to succeed while thesendmsgcall failed with an ECONNREFUSED error leading to the test crashing from the abort call.