Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not modify sys.argv inplace. #19

Closed
luator opened this issue Dec 16, 2022 · 2 comments
Closed

Do not modify sys.argv inplace. #19

luator opened this issue Dec 16, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@luator
Copy link
Member

luator commented Dec 16, 2022 •
edited
Loading

This is bad practice.

See https://gitlab.tuebingen.mpg.de/mrolinek/cluster_utils/-/blob/master/cluster/settings.py#L247

By @mseitzer (imported from GitLab)
@luator
Copy link
Member Author

luator commented Nov 28, 2023

I think the link above is not pointing to the correct line anymore. I guess the problem is here:
https://gitlab.tuebingen.mpg.de/mrolinek/cluster_utils/-/blob/e9d0c86c86ff3021e1abcb048472a25617e6deba/cluster/settings.py#L324 (should copy instead of just assigning a reference)

By Felix Widmaier on 2023-11-28T14:34:33 (imported from GitLab)

@luator luator added the question Further information is requested label Apr 16, 2024
@mseitzer mseitzer removed the question Further information is requested label Apr 16, 2024
@mseitzer mseitzer mentioned this issue May 29, 2024
Merged
3 tasks
@mseitzer
Copy link
Collaborator

mseitzer commented Jun 5, 2024 •
edited
Loading

Fixed by #104

@mseitzer mseitzer closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luator @mseitzer