Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong work of long-term backups #43

Open
popovn opened this issue Dec 27, 2021 · 1 comment
Open

Wrong work of long-term backups #43

popovn opened this issue Dec 27, 2021 · 1 comment
Milestone

Comments

@popovn
Copy link

popovn commented Dec 27, 2021

Each time the backup saves files in the directories "yearly, monthly, weekly".
The old "today's" versions are being erased

To work better with the disk, the file must be created once. When the number of stored files exceeds the threshold and you need to delete the oldest one, then transfer it to the directories in turn "weekly-> monthly->yearly" if it meets their conditions.

The move operation is much less overhead for the file system than creating 4 files each time when starting a backup

The yearly, monthly, weekly config is also not saved.

@marvinweber
Copy link
Owner

Hi & thanks for your improvement suggestion.

You're right, the current long-term backup process is not optimal. This "caused" by the fact, that this started as a very simple plugin just creating copies of the database at every save and adding new features just on top of it.

As soon as I find the time, I'll refactor/rebuild the plugin and also consider the fact of the suboptimal backup/cleanup process.

@marvinweber marvinweber added this to the 2.0 milestone Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants