feat: 58 automate feature tracking #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version is now being accessed from git context and stored with getVersion in pkg/config/app.go. I added some formatting to ensure we the version had 3 characters. Currently pulling from git gives 0.5 which fails while 0.5.0 is successful. Also modified the dockerfile to give appropriate context and permissions within the docker container.
Makefile and Dockerfile modified to inject VERSION during build. Also added docker-build and docker-compose-up commands to makefile for more streamlined commands. Chanted Version to var type to enable setting during build. within setDefaultConfig Version is formatted and reset with viper. Version is then explicitly set to AppConfig instance.
Modified makefile to remove @go mod tidy and add a set-version component which saves the version to VERSION in an internal folder on build I removed formatVersion function as it became unnecessary after fixing some GetInstance calls. Modified the dockerfile to add VERSION file and utilize make build command. modified components.go within masa-node-cli to dynamically pull and utilize the internal VERSION.
version will be added or replaced on each build/run
Added version.go to store Version modified Makefile to utilize ldflags for injection Removed getVersion function and simply imported internal/constants to set the Version Adjusted client and docker files to import Version correctly
removed explicit COPY
|
@jdutchak I need to remake this pull request since this isn't a clean branch. Will circle back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes # adding more inputs to discord channel message call
Notes for Reviewers
Signed commits