Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the port build on 10.9.5 . #1

Open
wants to merge 1 commit into
base: mascguy-webkit2-gtk-devel
Choose a base branch
from

Conversation

RJVB
Copy link

@RJVB RJVB commented Feb 25, 2024

provide a choice (subport) to install a build of the 4.1 API . It looks like this should install in parallel to the 4.0 build but that remains to be confirmed.

Currently it builds, links and installs, but currently with WEB_GL disabled. That could be related to my custom Mesa port providing OpenEGL and GLESv1,2 .
The MiniBrowser seems to work but hangs on opening about:gpu and Epiphany seems to be unable to render pages at all (but without the UI lockup). Both times I tried the new build I ended up getting a KP; once while in the MiniBrowser, once after running Epiphany and (quite soon after) a suspend/wake cycle.

I think I'll continue my tinkering on Linux for now, crossing my fingers that my Mac hasn't learnt a new daily KP trick...

provide a choice (subport) to install a build of the 4.1 API . It looks
like this should install in parallel to the 4.0 build but that remains
to be confirmed.

Currently it builds, links and installs, but currently with WEB_GL
disabled. That could be related to my custom Mesa port providing OpenEGL
and GLESv1,2 .
The MiniBrowser seems to work but hangs on opening about:gpu and Epiphany
seems to be unable to render pages at all (but without the UI lockup).
Both times I tried the new build I ended up getting a KP; once while
in the MiniBrowser, once after running Epiphany and (quite soon after)
a suspend/wake cycle.
mascguy pushed a commit that referenced this pull request Mar 3, 2024
This makes three changes to the patches for 10.4 and 10.5:

1) In the G3 patch, it removes the ppc7400 reference that was never
actually used, rather than updating it.  It still fixes the case that
is actually used.

2) It removes the patch for i386 assembler that has been
(approximately) incorporated upstream since v3.4.5.  The collision
with this patch was the reason for the patch failure.

3) For the gcc 4.2 test-build fix, it replaces the conditionally
applied patchfile with an unconditional patch controlled by an
environment variable, thereby keeping the source code consistent
across OS versions.  This new environment variable is now defined by
the Portfile when the compiler is gcc 4.2.

The patches for #1 and macports#3 are now in a single unified patchfile.

Closes: https://trac.macports.org/ticket/69380

TESTED:
Tested on 10.4-10.5 ppc, 10.5-10.6 ppc (x86_64 Rosetta), 10.4-10.6
i386, 10.4-12.x x86_64, and 11.x-14.x arm64.
Now builds and passes at least some tests on all tested platforms,
except 10.4 ppc +universal.
Test behavior on 10.6+ is essentially unchanged.  Tests on 10.4 and
10.5 have a few additional failures since v3.4.4 (the last version
that built successfully) due to new tests having been added.
@RJVB
Copy link
Author

RJVB commented Mar 12, 2024

Webkit2-gtk 2.40 requires C++20 and just now I see that one really needs clang-17 to build C++20 code: https://discourse.llvm.org/t/rfc-clang-17-0-6-would-be-minimum-version-to-build-llvm-in-c-20/75345/8 . Using something as older as clang-12 (like I did) could cause all kinds of unexpected behaviour because of silent miscompiles and could explain a number of the issues (inexplicable build failures) I've been grappling with too.

The problem is that clang++-17 really seems to require a more recent libc++ runtime, one that provides std::verbose_abort (IIRC).

I now have GCC12 (cited in the above discourse as an alternative for clang-17); I might muster my courage and see how this port builds using that compiler...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant