Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Icon> className height/width get overridden if no size is included #107

Open
willyrk1 opened this issue Apr 22, 2020 · 0 comments
Open

Comments

@willyrk1
Copy link
Contributor

willyrk1 commented Apr 22, 2020

Do you want to request a feature or report a bug?
Feature, mostly.
What is the current behavior?
If you want to set height/width for an <Icon> using className, you also have to include size='' or else the hard-coded default styles, height: 32, width: 32, will take precedence over your className height/width.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

What is the expected behavior?
If the size prop is not specified, it should default to '' (or whatever implementation allows height/width to be set by className without being overridden by hard-coded default styles).
Which versions of MDL, and which browser / OS are affected by this issue? Did this work in previous versions of MDL?
This has presumably always been the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant